Skip to content

CLN: avoid Block.get_values in io.sql #32524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2020
Merged

CLN: avoid Block.get_values in io.sql #32524

merged 1 commit into from
Mar 11, 2020

Conversation

jbrockmendel
Copy link
Member

This particular usage is especially non-transparent, since it is effectively blk.get_values().astype(object) which is apparently not equivalent to blk.get_values(object)

WillAyd
WillAyd approved these changes Mar 7, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jreback jreback added Clean IO SQL to_sql, read_sql, read_sql_query labels Mar 11, 2020
@jreback jreback added this to the 1.1 milestone Mar 11, 2020
@jreback jreback merged commit 3984df1 into pandas-dev:master Mar 11, 2020
@jbrockmendel jbrockmendel deleted the get_values-sql branch March 11, 2020 03:07
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@jbrockmendel @SeeminSyed
CLN: avoid Block.get_values in io.sql (pandas-dev#32524)
abdae04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @WillAyd @jreback