TST: fix test creating invalid CategoricalBlock #32519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Mar 9, 2020
| @@ -1745,6 +1745,10 @@ def __init__(self, values, placement, ndim=None): | |||
| values = self._maybe_coerce_values(values) | |||
| super().__init__(values, placement, ndim) | |||
|
|
|||
| if self.ndim == 2 and len(self.mgr_locs) != 1: | |||
There was a problem hiding this comment.
woa, why is this here? shouldn't this be in a higher level block construction?
There was a problem hiding this comment.
either goes here or in NonconsolidateableMixin (which should be merged into ExtensionBlock anyway)
There was a problem hiding this comment.
no this is not what i mean. how can we possibly get here when passing a Categorical? and if you can't except by directly constructing a manager, then this should be an assertion error.
There was a problem hiding this comment.
then this should be an assertion error.
sure, will update
jreback
approved these changes
Mar 11, 2020
|
k merge on green |
5 tasks
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
* TST: fix test creating invalid CategoricalBlock * ValueError->AssertionError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrect tests here turned up when trying to replace Block.get_values calls with simpler alternatives.