Skip to content

CLN: Suppres compile warnings of pandas/io/sas/sas.pyx #32517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

ShaharNaveh
Copy link
Member

  • ref Error on C Warnings #32163
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

This is the warning that get removed:

pandas/io/sas/sas.c: In function ‘__pyx_f_6pandas_2io_3sas_4_sas_rdc_decompress’:
pandas/io/sas/sas.c:3732:65: warning: ‘__pyx_v_ctrl_bits’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 3732 |     __pyx_t_8 = (((__pyx_v_ctrl_bits & __pyx_v_ctrl_mask) == 0) != 0);
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alimcmaster1 alimcmaster1 added the Build Library building on various platforms label Mar 7, 2020
@WillAyd
Copy link
Member

WillAyd commented Mar 7, 2020

If you wanted to look at #32163 and have a way to get stricter on warnings without solving all at once would certainly welcome it. Achievable through various GCC flags I think

@ShaharNaveh
Copy link
Member Author

@WillAyd You think it's possible to have the -Werror flag only for specific files? (to prevent regression to fixed files)

@WillAyd
Copy link
Member

WillAyd commented Mar 7, 2020 via email

@WillAyd WillAyd added this to the 1.1 milestone Mar 12, 2020
@WillAyd WillAyd merged commit 7f6a22c into pandas-dev:master Mar 12, 2020
@WillAyd
Copy link
Member

WillAyd commented Mar 12, 2020

Thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the CLN-warnings-sas branch March 13, 2020 16:59
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants