-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
[BUG] add consistency to_numeric on empty list #32512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a561ab3
[BUG] add consistency to_numeric on empty list
mikekutzma c7239d5
Add pytest.mark.parametrize to tests
mikekutzma 9ae3c69
Merge branch 'master' of https://github.com/pandas-dev/pandas
mikekutzma b97e10c
Add pytest.mark.parametrize to tests
mikekutzma cbac61f
Use len(values) to avoid numpy compat issues
mikekutzma 25403d3
Merge branch 'bugfix/32493' of github.com:mikekutzma/pandas into bugf…
mikekutzma b1ad5c1
Add whatsnew entry for 32493
mikekutzma e051ec9
[BUG] add consistency to_numeric on empty list
mikekutzma 587f142
Add pytest.mark.parametrize to tests
mikekutzma fa6a271
Use len(values) to avoid numpy compat issues
mikekutzma e19371e
Add whatsnew entry for 32493
mikekutzma a33732a
Merge remote-tracking branch 'upstream/master'
mikekutzma 8b45bf9
Merge branch 'bugfix/32493' of github.com:mikekutzma/pandas into bugf…
mikekutzma b6f44e4
Use not len() over len==0 in to_numeric for unsigned
mikekutzma 5c31deb
Merge branch 'master' of github.com:mikekutzma/pandas into bugfix/32493
mikekutzma f700281
Merge remote-tracking branch 'upstream/master' into bugfix/32493
mikekutzma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -627,3 +627,12 @@ def test_non_coerce_uint64_conflict(errors, exp): | |
else: | ||
result = to_numeric(ser, errors=errors) | ||
tm.assert_series_equal(result, ser) | ||
|
||
|
||
def test_downcast_empty(): | ||
dc_int = pd.to_numeric([], downcast="integer") | ||
dc_float = pd.to_numeric([], downcast="float") | ||
dc_us = pd.to_numeric([], downcast="unsigned") | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a comment that points to the original issue? something like:
Should do it |
||
assert np.array_equal(dc_int, dc_float) | ||
assert np.array_equal(dc_us, dc_float) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use
pytest.mark.parametrize
here?