CLN: Avoid bare pytest.raises in computation/test_eval.py #32507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 5, 2020 21:09
within the test_eval.py file. I have been working on this for ~30 minutes so far.
…999_disallow_bare_pytest_raises_test_eval
…999_disallow_bare_pytest_raises_test_eval
that were different for Mac and Linux. These should be compliant across the six or so different builds that it did not before.
datapythonista
changed the title
datapythonista
added
Clean
Testing
gfyoung
approved these changes
Mar 10, 2020
|
Thanks @Vlek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref [Good first issue] TST: Disallow bare pytest.raises #30999
tests added / passed
passes
black pandaspasses
git diff origin/master -u -- "*.py" | flake8 --diff