Skip to content

CLN: Replace isinstance(foo, Class) with isinstance(foo, ABCClass) #32485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

CLN: Replace isinstance(foo, Class) with isinstance(foo, ABCClass) #32485

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0133b7
CLN: Using ABCClass instead of Class in "isinstance()"
Mar 6, 2020
26b8ad9
isort formatting
Mar 6, 2020
aad4788
Revert "isort formatting"
Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pandas/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@
)

from pandas.core.arrays.sparse import SparseDtype
from pandas.core.dtypes.generic import ABCSparseArray

from pandas.tseries.api import infer_freq
from pandas.tseries import offsets
Expand Down Expand Up @@ -341,7 +342,7 @@ class __SparseArray(type):
SparseArray = sa

def __instancecheck__(cls, other):
return isinstance(other, cls.SparseArray)
return isinstance(other, ABCSparseArray)

class __SparseArraySub(metaclass=__SparseArray):
def emit_warning(dummy=0):
Expand Down