TST/VIZ: add test for legend colors for DataFrame with duplicate column labels #11136 #32451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/tests/plotting/test_frame.py
Outdated
| @@ -3316,6 +3316,22 @@ def test_missing_markers_legend_using_style(self): | |||
| self._check_legend_labels(ax, labels=["A", "B", "C"]) | |||
| self._check_legend_marker(ax, expected_markers=[".", ".", "."]) | |||
|
|
|||
| def test_colors_of_columns_with_same_name( | |||
There was a problem hiding this comment.
something like test_legend_colors_duplicate_labels ?
There was a problem hiding this comment.
Thanks for the reply, i have just made the changes . Can you check if is everything right now?
simonjayhawkins
added
Testing
simonjayhawkins
changed the title
|
I have just made the changes. Can you check if is everything right now? Really thanks! |
|
Fix were made, the for syntax is better now and now im using methods from matplotlib like get_color() and get_legend(). |
simonjayhawkins
approved these changes
Mar 10, 2020
WillAyd
approved these changes
Mar 12, 2020
|
Great thanks @gabrielvf1 |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff