DOC: Fix EX02 in pandas.Index.get_loc #32429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Thanks @farhanreynaldo
In the future I think it would help to also post the output of
python scripts/validate_docstrings.py pandas.Index.get_loc
which here is
################################################################################
################################## Validation ##################################
################################################################################
5 Errors found:
No extended summary found
Parameter "key" has no description
The first line of the Returns section should contain only the type, unless multiple values are being returned
Return value has no description
See Also section not found
to show that the doctests now pass
|
Also, adding to the pull request description would be good |
Thank you for the reminder, @MarcoGorelli, I will add it next time. |
WillAyd
approved these changes
Mar 4, 2020
|
Great thanks @farhanreynaldo for PR and @MarcoGorelli for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffRelated to #27977.