WIP: ENH: Add engine keyword argument to groupby.apply to leverage Numba #32428
Conversation
|
Hello @mroeschke! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-03-04 08:40:09 UTC |
| @@ -223,8 +223,10 @@ def _selection_name(self): | |||
| input="series", examples=_apply_docs["series_examples"] | |||
| ) | |||
| ) | |||
| def apply(self, func, *args, **kwargs): | |||
| return super().apply(func, *args, **kwargs) | |||
| def apply(self, func, engine="cython", engine_kwargs=None, *args, **kwargs): | |||
There was a problem hiding this comment.
will want to update the doc-strings as well
| from pandas.compat._optional import import_optional_dependency | ||
|
|
||
|
|
||
| class InvalidApply(Exception): |
There was a problem hiding this comment.
why do you need a new exception?
There was a problem hiding this comment.
Sure will want to import this from its original location in cython. Or we can move InvalidApply to pandas.errors
| ) | ||
|
|
||
|
|
||
| def make_groupby_apply( |
There was a problem hiding this comment.
can we share pandas/core/window/numba_.py at all? maybe put common functions in pandas/core/algos/numba_.py (we have another issue about creating this and moving pandas/core/aggregation.py and algorithms.py to there
There was a problem hiding this comment.
Definitely, will consolidate in another commit.
|
Closing as I am going to try to address this in another fashion |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff