Skip to content

CLN: avoid _internal_get_values in groupby.generic #32427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2020
Merged

CLN: avoid _internal_get_values in groupby.generic #32427

merged 1 commit into from
Mar 5, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Mar 4, 2020 •
edited by simonjayhawkins
Loading

xref #27165, #27167

@WillAyd
Copy link
Member

WillAyd commented Mar 4, 2020

Looks good - are we just getting rid of internal_get_values entirely?

@WillAyd WillAyd added the Clean label Mar 4, 2020
@jbrockmendel
Copy link
Member Author

are we just getting rid of internal_get_values entirely

Thats the goal, xref #27165, #27167

@WillAyd WillAyd added this to the 1.1 milestone Mar 5, 2020
@simonjayhawkins simonjayhawkins merged commit 79c9ec9 into pandas-dev:master Mar 5, 2020
@simonjayhawkins
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the internal_get_values-grouoby branch March 5, 2020 15:00
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@simonjayhawkins @SeeminSyed
CLN: avoid _internal_get_values in groupby.generic (pandas-dev#32427)
393562d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @WillAyd @simonjayhawkins