Fix BUG: overflow on pd.Timedelta(nanoseconds=) constructor #32424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Mar 3, 2020
| @@ -16,6 +16,8 @@ | |||
| (1, 1), | |||
| (np.int64(2), 2), | |||
| (np.int32(3), 3), | |||
| (Timedelta(1e10), 1e10), | |||
There was a problem hiding this comment.
I think this is worthy of its own test rather than parametrizing - can you separate this out?
There was a problem hiding this comment.
Sure, no problem. Is it useful to mark the test with a reference to the ticket?
Is this file OK? Or is there a better one?
There was a problem hiding this comment.
Totally - just add # GH 32402 in the body of the test
|
@jreback care to take a look? |
roberthdevries
force-pushed
the
fix-34202-overflow-on-pd-timedelta-nanoseconds
branch
from
422497f to
9ac50f4
Compare
|
thanks @roberthdevries very nice |
roberthdevries
deleted the
fix-34202-overflow-on-pd-timedelta-nanoseconds
branch
simonjayhawkins
added a commit
to simonjayhawkins/pandas
that referenced
this pull request
Mar 4, 2020
simonjayhawkins
added a commit
that referenced
this pull request
Mar 5, 2020
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add regression test
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff