Skip to content

Properly handle missing attributes in query/eval strings #32408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 10, 2020
Merged

Properly handle missing attributes in query/eval strings #32408

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0e817b7
Properly handle missing attributes in query/eval strings
alexmojaki Mar 3, 2020
f392c60
Use type(ctx) instead of ctx.__class__
alexmojaki Mar 5, 2020
8f1ae2b
Properly handle missing attributes in query/eval strings
alexmojaki Mar 3, 2020
ef046fb
Use type(ctx) instead of ctx.__class__
alexmojaki Mar 5, 2020
9e0ba6c
Add test_missing_attribute
alexmojaki Mar 15, 2020
49ac9b6
Add whatsnew note about missing attributes
alexmojaki Mar 17, 2020
f77f119
Merge branch 'master' into eval-attribute-error
jreback Mar 19, 2020
61bf5af
Merge branch 'master' of github.com:pandas-dev/pandas into eval-attri…
alexmojaki Apr 3, 2020
589a230
Merge branch 'eval-attribute-error' of github.com:alexmojaki/pandas i…
alexmojaki Apr 3, 2020
33d55e4
Merge branch 'master' of github.com:pandas-dev/pandas into eval-attri…
alexmojaki Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pandas/core/computation/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,8 +635,9 @@ def visit_Attribute(self, node, **kwargs):
# something like datetime.datetime where scope is overridden
if isinstance(value, ast.Name) and value.id == attr:
return resolved
raise

raise ValueError(f"Invalid Attribute context {ctx.__name__}")
raise ValueError(f"Invalid Attribute context {type(ctx).__name__}")

def visit_Call(self, node, side=None, **kwargs):

Expand Down