TYP: internals #32403
Merged
TYP: internals #32403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Mar 3, 2020
| """ return an empty BlockManager with the items axis of len 0 """ | ||
| if axes is None: | ||
| axes = [ensure_index([])] + [ensure_index(a) for a in self.axes[1:]] | ||
| axes = [Index([])] + self.axes[1:] |
There was a problem hiding this comment.
Not an error, just unnecessarily complicated
simonjayhawkins
approved these changes
Mar 3, 2020
| @@ -807,7 +812,7 @@ def _interleave(self): | |||
| # TODO: https://github.com/pandas-dev/pandas/issues/22791 | |||
| # Give EAs some input on what happens here. Sparse needs this. | |||
| if is_sparse(dtype): | |||
| dtype = dtype.subtype | |||
| dtype = dtype.subtype # type: ignore | |||
There was a problem hiding this comment.
according to the docstring, is_sparse is to check arrays. so isinstance(dtype, SparseDtype) could be used here to avoid the ignore?
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some of these are a real bear, in particular
SingleBlockManager.__init__