Skip to content

TST: add message check to pytest.raises (tests/arrays/test_boolean.py) #32397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2020
Merged

TST: add message check to pytest.raises (tests/arrays/test_boolean.py) #32397

merged 2 commits into from
Mar 3, 2020

Conversation

ShilpaSugan
Copy link
Contributor

@ShilpaSugan ShilpaSugan commented Mar 2, 2020 •
edited
Loading

simonjayhawkins
simonjayhawkins reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShilpaSugan generally lgtm. I think we have a check that whitespace is at the end of the strings, so if the CI fails may need to change that.

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Mar 2, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Mar 2, 2020
@simonjayhawkins simonjayhawkins changed the title Fixed boolean test TST: add message check to pytest.raises (tests/arrays/test_boolean.py) Mar 2, 2020
simonjayhawkins
simonjayhawkins approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ShilpaSugan lgtm pending green

@simonjayhawkins simonjayhawkins merged commit 0dc93cd into pandas-dev:master Mar 3, 2020
@ShilpaSugan ShilpaSugan deleted the 309999_fix_bare_pytest_raises branch March 3, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ShilpaSugan @simonjayhawkins