Skip to content

DOC: change link to contributing guide in README.md #32393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2020

Conversation

simonjayhawkins
Copy link
Member

@jbrockmendel
Copy link
Member

LGTM

README.md Outdated
@@ -158,7 +158,7 @@ Most development discussion is taking place on github in this repo. Further, the

All contributions, bug reports, bug fixes, documentation improvements, enhancements and ideas are welcome.

A detailed overview on how to contribute can be found in the **[contributing guide](https://dev.pandas.io/docs/contributing.html)**. There is also an [overview](.github/CONTRIBUTING.md) on GitHub.
A detailed overview on how to contribute can be found in the **[contributing guide](https://pandas.io/docs/development/contributing.html)**. There is also an [overview](.github/CONTRIBUTING.md) on GitHub.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave the dev. for now? (until we have a proper place for the dev docs) The link you are changing it to now are the stable docs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link you are changing it to now are the stable docs

see #32068 (comment)

dev docs are stale

image

this new link is not the stable docs

image

@datapythonista
Copy link
Member

Working on the actual fix now, see #32530

@simonjayhawkins
Copy link
Member Author

Thanks @datapythonista

@simonjayhawkins simonjayhawkins restored the temp-link branch April 8, 2020 09:41
@simonjayhawkins
Copy link
Member Author

Can you leave the dev. for now? (until we have a proper place for the dev docs) The link you are changing it to now are the stable docs

updated.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks Simon

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Apr 8, 2020
@simonjayhawkins simonjayhawkins merged commit 75fb640 into pandas-dev:master Apr 8, 2020
@simonjayhawkins simonjayhawkins deleted the temp-link branch April 13, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants