REF: collect+parametrize reorder_levels tests #32373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| # no change, position | ||
| result = obj.reorder_levels([0, 1, 2]) | ||
| tm.assert_equal(obj, result) |
There was a problem hiding this comment.
if this is going to happen a lot with these changes, should maybe consider a solution that can maintain the correct assertion helper.
either in the parameterisation as "klass, helper" or create a fixture something like
@fixture()
def assert_klass_equal(klass):
if isinstance(klass, DataFrame):
return tm.assert_frame_equal
elif isinstance(klass, Series):
return tm.assert_series_equal
else:
assert False
(code not tested!)
There was a problem hiding this comment.
might make sense to add as a kwarg to tm.assert_equal
There was a problem hiding this comment.
yeah, that sounds good as well. could be follow-up
simonjayhawkins
added
the
Testing
simonjayhawkins
approved these changes
Mar 2, 2020
|
Thanks @jbrockmendel |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.