TYP/cln: generic._make_*_function #32363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Feb 29, 2020
| name2: str, | ||
| axis_descr: str, | ||
| desc: str, | ||
| func: Callable, |
There was a problem hiding this comment.
Is it possible to add subtypes here or no?
There was a problem hiding this comment.
The passed functions don't have the same signature, because e.g. nansum has a min_count parameter and nankurt does not. So it's not possible without splitting the function into two, which IMO is not worth it.
|
LGTM |
WillAyd
requested changes
Mar 4, 2020
pandas/core/generic.py
Outdated
| accum_func: Callable, | ||
| accum_func_name: str, | ||
| mask_a: Union[float, np.floating], | ||
| mask_b: Union[float, np.floating], |
There was a problem hiding this comment.
Suggested change
| mask_b: Union[float, np.floating], | |
| mask_b: float, |
topper-123
force-pushed
the
cln_generic_make_x_function
branch
from
e120260 to
0c3db7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give calls to these funcs named parameters for better clarity + type up the make_stats functions.