Changed kind parameter from integer to int, Added example #32361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaharNaveh
suggested changes
Feb 29, 2020
pandas/core/arrays/sparse/array.py
Outdated
| @@ -231,7 +231,7 @@ class SparseArray(PandasObject, ExtensionArray, ExtensionOpsMixin): | |||
| 3. ``data.dtype.fill_value`` if `fill_value` is None and `dtype` | |||
| is not a ``SparseDtype`` and `data` is a ``SparseArray``. | |||
|
|
|||
| kind : {'integer', 'block'}, default 'integer' | |||
| kind : {'int', 'block'}, default 'int' | |||
There was a problem hiding this comment.
Hey, thanks for the reply :)
After reverting the line, an error pops up on the validate_doctring.py test, is that ok?
@MomIsBestFriend
################################################################################
################################## Validation ##################################
################################################################################
4 Errors found:
Parameter "sparse_index" has no description
Parameter "index" has no description
**Parameter "kind" type should use "int" instead of "integer"**
See Also section not found
There was a problem hiding this comment.
This is a known bug with the validator (see #25205) so just have to ignore for now
WillAyd
approved these changes
Feb 29, 2020
|
Great thanks @mackarelfish ! |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff