Skip to content

Fixing RT02 pandas.Index.dropna and PR08 pandas.Index.fillna #32359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Fixing RT02 pandas.Index.dropna and PR08 pandas.Index.fillna #32359

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f66c1a3
Fixing RT02 pandas.Index.dropna and PR08 pandas.Index.fillna
zaki-indra Feb 29, 2020
88deb68
Update base.py
WillAyd Mar 4, 2020
8534654
Merge remote-tracking branch 'upstream/master' into fix-docstring
WillAyd Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pandas/core/indexes/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2130,7 +2130,7 @@ def fillna(self, value=None, downcast=None):
Scalar value to use to fill holes (e.g. 0).
This value cannot be a list-likes.
downcast : dict, default is None
a dict of item->dtype of what to downcast if possible,
A dict of item->dtype of what to downcast if possible,
or the string 'infer' which will try to downcast to an appropriate
equal type (e.g. float64 to int64 if possible).

Expand Down Expand Up @@ -2159,7 +2159,8 @@ def dropna(self, how="any"):

Returns
-------
valid : Index
valid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
valid
Index

Can just list the type of object being returned here

Index
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this line

"""
if how not in ("any", "all"):
raise ValueError(f"invalid how option: {how}")
Expand Down