DOC: Fixed ES01, PR07, SA04 error in pandas.core.groupby.DataFrameGroupBy.shift #32356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iqrar99
changed the title
Iqrar99
changed the title
WillAyd
requested changes
Feb 29, 2020
pandas/core/groupby/groupby.py
Outdated
| fill_value : optional | ||
| The scalar value to use for newly introduced missing values. | ||
| The default depends on the dtype of *self*. |
There was a problem hiding this comment.
I think OK to remove this and the next 3 lines
pandas/core/groupby/groupby.py
Outdated
| def shift(self, periods=1, freq=None, axis=0, fill_value=None): | ||
| """ | ||
| Shift each group by periods observations. | ||
|
|
||
| When freq is not passed, shift the index without realigning the data. |
There was a problem hiding this comment.
I think should remove this first line (second is OK to keep)
pandas/core/groupby/groupby.py
Outdated
| See Also | ||
| -------- | ||
| Index.shift : Shift values of Index. | ||
| DatetimeIndex.resample : Shift values of DatetimeIndex. |
There was a problem hiding this comment.
Let's remove DatetimeIndex.resample and PeriodIndex.shift as neither are public (this docstring is)
WillAyd
approved these changes
Mar 2, 2020
|
Great thanks @Iqrar99 ! |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
|
You are welcome! 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffOutput of python scripts/validate_docstrings.py pandas.core.groupby.DataFrameGroupBy.shift: