Skip to content

Fix PR08, RT02, RT03, and SA01 on pandas.Index.fillna #32355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2020

Conversation

RafifEL
Copy link
Contributor

@RafifEL RafifEL commented Feb 29, 2020

@ShaharNaveh
Copy link
Member

Why was all of those files in c4099b5 was removed?

@WillAyd
Copy link
Member

WillAyd commented Feb 29, 2020

@RafifEL looks like something went awry with the git workflow here. Can you git checkout master FILENAME for all the files you didn't update the docstring in and re-push?

@RafifEL
Copy link
Contributor Author

RafifEL commented Feb 29, 2020

@RafifEL looks like something went awry with the git workflow here. Can you git checkout master FILENAME for all the files you didn't update the docstring in and re-push?

I'm sorry, I'm new to this stuff, is there anyway for me to hard reset to 1dbea46 commit?

@WillAyd
Copy link
Member

WillAyd commented Mar 1, 2020

Sure! From your branch try:

git reset --hard 1dbea46
git push -f origin rafif-feature

@RafifEL
Copy link
Contributor Author

RafifEL commented Mar 1, 2020

Why was all of those files in c4099b5 was removed?

I'm Sorry, i was trying to see the HTML of the documentation by using "python doc/make.py html". It got an Error, so i delete the reference folder on this branch to see it.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job getting back to a clean state. Just some minor fixups otherwise should be good to go here

or the string 'infer' which will try to downcast to an appropriate
equal type (e.g. float64 to int64 if possible).

Returns
-------
filled : Index
filled
Index.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this line altogether

@WillAyd WillAyd added this to the 1.1 milestone Mar 4, 2020
@WillAyd WillAyd merged commit 609b8da into pandas-dev:master Mar 4, 2020
@WillAyd
Copy link
Member

WillAyd commented Mar 4, 2020

Thanks @RafifEL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants