DOC : fix errors docstrings pandas.to_numeric #32354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaharNaveh
suggested changes
Feb 29, 2020
pandas/core/tools/numeric.py
Outdated
| errors : {'ignore', 'raise', 'coerce'}, default 'raise' | ||
| - If 'raise', then invalid parsing will raise an exception. | ||
| - If 'coerce', then invalid parsing will be set as NaN. | ||
| - If 'ignore', then invalid parsing will return the input. | ||
| downcast : {'integer', 'signed', 'unsigned', 'float'}, default None | ||
| downcast : {'int', 'signed', 'unsigned', 'float'}, default None |
There was a problem hiding this comment.
Please change this back to integer, you are completely right when it comes to the type of rhe variable that we want the python type name and not the pre-historic name, but in this case it's the value, and code below will check if downcast is equals to integer and not for int
There was a problem hiding this comment.
alright, ill be back soon
pandas/core/tools/numeric.py
Outdated
| If not None, and if the data has been successfully cast to a | ||
| numerical dtype (or if the data was numeric to begin with), | ||
| downcast that resulting data to the smallest numerical dtype | ||
| possible according to the following rules: | ||
|
|
||
| - 'integer' or 'signed': smallest signed int dtype (min.: np.int8) | ||
| - 'int' or 'signed': smallest signed int dtype (min.: np.int8) |
isoletslicer
commented
Mar 3, 2020
WillAyd
approved these changes
Mar 6, 2020
|
Thanks @isoletslicer |
isoletslicer
changed the title
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffadded docstrings information about arg descriptions, downcast type 'int', and Return type