REF: Remove BlockManager.rename_axis #32349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Clean
Internals
jreback
requested changes
Mar 3, 2020
pandas/core/indexes/api.py
Outdated
| @@ -311,3 +311,24 @@ def all_indexes_same(indexes): | |||
| if not first.equals(index): | |||
| return False | |||
| return True | |||
|
|
|||
|
|
|||
| def transform_index(index: Index, func, level=None) -> Index: | |||
There was a problem hiding this comment.
how is this different from .map?
There was a problem hiding this comment.
Looks like the main difference is in the MultiIndex case passing level makes this operate on just that levle
There was a problem hiding this comment.
k, it would be better to use map then than duplicating this code
There was a problem hiding this comment.
or at least co-locate as a private function for future de-duplication
jreback
approved these changes
Mar 11, 2020
|
k thanks, with the followon comments about deduplicating (I see you made a comment) |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better to do it using NDFrame methods
cc @toobaz I know you're on board for getting index/axis stuff out of BlockManager.