BUG: None / Timedelta incorrectly returning NaT #32340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not against the design just curious as to what your thought is as to why this should raise instead of returning NaN? Perhaps because np.nan / pd.NaT is ambiguous? |
WillAyd
added
Missing-data
Think of it as if we had non-NA scalars of the same types/dtypes. e.g. |
jreback
reviewed
Mar 3, 2020
| # GH#31869 None gets cast to NaT | ||
| td = Timedelta(10, unit="d") | ||
|
|
||
| result = NaT / td |
There was a problem hiding this comment.
maybe as a follown split out the these non-error casees and use nulls_fixture (as you then can test float('nan')
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffxref #31869, arguable whether or not this closes that.