Skip to content

TST/REF: move tools test files #32338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 29, 2020

Conversation

jbrockmendel
Copy link
Member

These files are in the index tests, but they're not really testing the index objects.

@simonjayhawkins
Copy link
Member

i'm not sure about date_range, period_range and timedelta_range as these only return Indexes and so are effectively Index constructors. see what others think.

the others make more sense. (the return value in the docs for pandas.to_timedelta https://dev.pandas.io/docs/reference/api/pandas.to_timedelta.html appears incorrect. Should be scalar, Series or TimedeltaIndex?)

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Feb 28, 2020
@jbrockmendel
Copy link
Member Author

i'm not sure about date_range, period_range and timedelta_range as these only return Indexes and so are effectively Index constructors.

Thats reasonable. My thought is that these are top-level convenience functions, and the directories they are currently in are getting crowded (and likely to become more so)

@mroeschke
Copy link
Member

I agree with @simonjayhawkins. I tend to view these as "constructors" more than "tools".

How about pandas/tests/indexes/datetimes/constructors/test_date_range.py and then pandas/tests/indexes/datetimes/test_constructors.py could be pandas/tests/indexes/datetimes/constructor/test_datetimeindex.py or something?

@jbrockmendel
Copy link
Member Author

will revert the non-consensus changes

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 29, 2020
@simonjayhawkins simonjayhawkins merged commit 01f3998 into pandas-dev:master Feb 29, 2020
@simonjayhawkins
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the tst-tools branch February 29, 2020 20:13
sthagen added a commit to sthagen/pandas-dev-pandas that referenced this pull request Feb 29, 2020
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants