Skip to content

CLN: Don't create _join_functions #32336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2020
Merged

CLN: Don't create _join_functions #32336

merged 1 commit into from
Mar 3, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Feb 28, 2020

This seems more clear than defining _join_functions far away from where it's actually used

@jbrockmendel
Copy link
Member

Seems fine

WillAyd
WillAyd approved these changes Feb 29, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added the Clean label Feb 29, 2020
@WillAyd WillAyd added this to the 1.1 milestone Feb 29, 2020
@jreback jreback merged commit 94fdc30 into pandas-dev:master Mar 3, 2020
@jreback
Copy link
Contributor

jreback commented Mar 3, 2020

thanks @dsaxton

@dsaxton dsaxton deleted the cln-merge branch April 9, 2020 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@dsaxton @jbrockmendel @jreback @WillAyd