Skip to content

CLN: remove _igetitem_cache #32319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2020
Merged

CLN: remove _igetitem_cache #32319

merged 1 commit into from
Mar 3, 2020

Conversation

jbrockmendel
Copy link
Member

Only used once (recent bugfixes got rid of the user uses IIRC) and its just an extra layer that isnt needed.

@jbrockmendel jbrockmendel added the Indexing Related to indexing on series/frames, not to indexes themselves label Feb 28, 2020
jorisvandenbossche
jorisvandenbossche reviewed Mar 2, 2020
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this a performance implication?

@jbrockmendel
Copy link
Member Author

Has this a performance implication?

The only user-facing paths affected are iat.__setitem__ and at.__setitem__. With unique columns this is 3x slower because we are no longer caching a Series object. With non-unique columns this is ~4% faster because of a skipped check. The benefit is in getting rid of the code path.

@jreback jreback added this to the 1.1 milestone Mar 3, 2020
jreback
jreback approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@jreback jreback merged commit 712fd01 into pandas-dev:master Mar 3, 2020
@jbrockmendel jbrockmendel deleted the igetitem_cache branch March 3, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @jorisvandenbossche