Skip to content

BUG: PeriodIndex.asof_locs #32310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2020
Merged

Conversation

jbrockmendel
Copy link
Member

No description provided.

@jbrockmendel jbrockmendel added the Indexing Related to indexing on series/frames, not to indexes themselves label Feb 28, 2020
@jreback jreback added this to the 1.1 milestone Mar 3, 2020
@jreback
Copy link
Contributor

jreback commented Mar 3, 2020

looks fine. does this have any user facing impliacations? e.g. does it need a whatsnew

@jbrockmendel
Copy link
Member Author

does this have any user facing impliacations? e.g. does it need a whatsnew

passing nonsense (e.g. an Int64Index) to Series.asof with a PeriodIndex will now raise instead of silently being wrong

@jreback jreback merged commit 00f1825 into pandas-dev:master Mar 8, 2020
@jreback
Copy link
Contributor

jreback commented Mar 8, 2020

thanks !

@jbrockmendel jbrockmendel deleted the no-ndarray_values branch March 8, 2020 16:04
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants