Skip to content

ENH: Move corrwith from transformation to reduction kernels in groupby.base #32294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 12, 2020
Merged

ENH: Move corrwith from transformation to reduction kernels in groupby.base #32294

merged 6 commits into from
Mar 12, 2020

Conversation

fujiaxiang
Copy link
Member

@fujiaxiang fujiaxiang commented Feb 27, 2020 •
edited
Loading

@fujiaxiang fujiaxiang requested a review from WillAyd February 28, 2020 01:12
@jreback
Copy link
Contributor

jreback commented Mar 3, 2020

this looks correct, but @TomAugspurger if you'd have a look.

@TomAugspurger
Copy link
Contributor

What's the user-facing change here? Can you add that to the release note?

@fujiaxiang
Copy link
Member Author

What's the user-facing change here? Can you add that to the release note?

There change doesn't affect users. However this allows us to make subsequent changes that have benefit users.

@fujiaxiang
Copy link
Member Author

ping

WillAyd
WillAyd requested changes Mar 11, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit otherwise lgtm

@WillAyd WillAyd added this to the 1.1 milestone Mar 11, 2020
WillAyd
WillAyd approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jreback
jreback approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge on green.

@WillAyd WillAyd merged commit bb4395e into pandas-dev:master Mar 12, 2020
@WillAyd
Copy link
Member

WillAyd commented Mar 12, 2020

Thanks @fujiaxiang

SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@fujiaxiang @SeeminSyed
ENH: Move corrwith from transformation to reduction kernels in groupb…
7ef7dd0 
…y.base (pandas-dev#32294)
@fujiaxiang fujiaxiang deleted the move_corrwith_to_reduction_kernels branch May 29, 2020 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Groupby
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

ENH: Move "corrwith" from transformation_kernels to reduction_kernels in groupby.base
4 participants
@fujiaxiang @jreback @TomAugspurger @WillAyd