BUG: groupby with sort=False creates buggy MultiIndex #32291
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Feb 27, 2020
pandas/tests/groupby/test_groupby.py
Outdated
| @@ -2015,6 +2015,29 @@ def test_dup_labels_output_shape(groupby_func, idx): | |||
| tm.assert_index_equal(result.columns, idx) | |||
|
|
|||
|
|
|||
| def test_multiindex_lexsorted(): | |||
There was a problem hiding this comment.
note to self - add GH note here :)
|
can you set the names of PRs to be the similar to the issue |
MarcoGorelli
changed the title
MarcoGorelli
force-pushed
the
issue-32259
branch
2 times, most recently
from
08643fc to
64e3d4a
Compare
|
harder than I thought, closing for now, will return to it at later stage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffEDIT
probably better/less invasive to make sure .groupby(, sort=False) returns an object where the index has codes which reflect the ordering