REF: make DatetimeIndex._simple_new actually simple #32282
Conversation
jbrockmendel
added
Refactor
| @@ -36,7 +32,16 @@ def _new_DatetimeIndex(cls, d): | |||
| if "data" in d and not isinstance(d["data"], DatetimeIndex): | |||
| # Avoid need to verify integrity by calling simple_new directly | |||
| data = d.pop("data") | |||
| result = cls._simple_new(data, **d) | |||
| if not isinstance(data, DatetimeArray): | |||
There was a problem hiding this comment.
backward compat for old pickles
There was a problem hiding this comment.
can you make this nicer. it is very hard to grok.
pandas/tseries/offsets.py
Outdated
| @@ -1155,7 +1155,12 @@ def apply_index(self, i): | |||
| shifted = liboffsets.shift_months(i.asi8, self.n, self._day_opt) | |||
| # TODO: going through __new__ raises on call to _validate_frequency; | |||
| # are we passing incorrect freq? | |||
| return type(i)._simple_new(shifted, freq=i.freq, dtype=i.dtype) | |||
| dta = i | |||
| if not isinstance(i._data, np.ndarray): | |||
There was a problem hiding this comment.
compat for getting either a DTA or a DTI, we already do this in a couple places. I think we can do it just once by putting it in the apply_index_wraps decorator
| @@ -816,7 +809,10 @@ def _fast_union(self, other, sort=None): | |||
| loc = right.searchsorted(left_end, side="right") | |||
| right_chunk = right.values[loc:] | |||
| dates = concat_compat((left.values, right_chunk)) | |||
| return self._shallow_copy(dates) | |||
| result = self._shallow_copy(dates) | |||
| result._set_freq("infer") | |||
There was a problem hiding this comment.
you could change _set_freq to return self to make this idiom more clear (also _set_freq should be marked in the doc-string as a mutating function)
There was a problem hiding this comment.
Holding off on this since _set_freq needs a bigger rethink, xref #31218.
All other comments addressed, i think
|
comments addressed + green |
|
thanks |
|
alright! i think with this the only _simple_new that isnt actually simple is IntervalArray |
No description provided.