Implement __array__ on ExtensionIndex #32255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Mar 3, 2020
|
|
||
|
|
||
| @pytest.mark.parametrize("array", [True, False]) | ||
| def test_dunder_array(array): |
There was a problem hiding this comment.
do we have this test for indexes generally?
jreback
added
ExtensionArray
|
looks ok. @TomAugspurger if you'd have a look. |
|
do we have an issue for adding |
There was a problem hiding this comment.
Don't see an issue for Index.__array_ufunc__. Opened #32411 as a placeholder.
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -90,6 +90,8 @@ Backwards incompatible API changes | |||
| now raise a ``TypeError`` if a not-accepted keyword argument is passed into it. | |||
| Previously a ``UnsupportedFunctionCall`` was raised (``AssertionError`` if ``min_count`` passed into :meth:`~DataFrameGroupby.median``) (:issue:`31485`) | |||
| - :meth:`DataFrame.at` and :meth:`Series.at` will raise a ``TypeError`` instead of a ``ValueError`` if an incompatible key is passed, and ``KeyError`` if a missing key is passed, matching the behavior of ``.loc[]`` (:issue:`31722`) | |||
| - Passing an integer dtype other than ``int64`` to ``np.array(period_index, dtype=...)`` will now raise ``NotImplementedError`` instead of incorrectly using ``int64`` (:issue:`32255`) | |||
There was a problem hiding this comment.
Why NotImplementedError, rathan something like ValueError? Are we the ones raising it, or is NumPy?
There was a problem hiding this comment.
Though from the tests, it looks like a TypeError is raised (unless I'm misreading).
jreback
approved these changes
Mar 4, 2020
| elif dtype == bool: | ||
| return ~self._isnan | ||
|
|
||
| # This will raise TypeErorr for non-object dtypes |
|
Thanks @jbrockmendel |
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.