Skip to content

REF: method-specific file for to_timestamp #32248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

jbrockmendel
Copy link
Member

cc @MomIsBestFriend this is the only test we have for DataFrame.to_timestamp, but it was apparently written before the convention of "small, focused tests" took hold. It would be helpful if this could be split/modernized.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Feb 26, 2020
@jreback jreback added this to the 1.1 milestone Feb 26, 2020
@jreback jreback merged commit 7c7048c into pandas-dev:master Feb 26, 2020
@jreback
Copy link
Contributor

jreback commented Feb 26, 2020

thanks, love to have split big tests when you can. maybe a way to run a linter to see what are long-ish tests

@jbrockmendel jbrockmendel deleted the tst-methods-11 branch February 26, 2020 02:04
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants