CLN: simplify+annotate _shallow_copy #32244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Clean
Constructors
simonjayhawkins
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
@jbrockmendel lgtm
a few inconsistencies between the methods. such as name = self.name if name is no_default else name vs name = name if name is not lib.no_default else self.name and name: Label = no_default vs name: Label = lib.no_default but not blocker.
| return self._simple_new(self._range, name=name) | ||
| else: | ||
| kwargs.setdefault("name", self.name) | ||
| return self._int64index._shallow_copy(values, **kwargs) | ||
| return Int64Index._simple_new(values, name=name) |
There was a problem hiding this comment.
why is self._int64index replaced with Int64Index? does this affect subclassing?
There was a problem hiding this comment.
Using Int64Index is more direct, avoids constructing self._int64index
Shouldn't affect subclasses, which isn't really supported anyway.
Yah, that's just a matter of which modules already have |
|
thanks |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntervalIndex is still an outlier, will be handled separately