Skip to content

Fix exception causes in 14 modules #32235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Feb 25, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@cool-RR
Copy link
Contributor Author

cool-RR commented Feb 25, 2020

This covers around half of the project. We could do the rest later.

@cool-RR cool-RR marked this pull request as ready for review February 25, 2020 11:05
@cool-RR
Copy link
Contributor Author

cool-RR commented Feb 25, 2020

Any idea why some checks are failing? I'm seeing "ImportError: No module named conda.cli" but I don't see how that's related to my PR.

@simonjayhawkins
Copy link
Member

Any idea why some checks are failing? I'm seeing "ImportError: No module named conda.cli" but I don't see how that's related to my PR.

failing CI should be fixed now. can you merge master.

@simonjayhawkins simonjayhawkins added the Error Reporting Incorrect or improved errors from pandas label Feb 25, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 25, 2020
@cool-RR cool-RR force-pushed the 2020-02-22-raise-from branch from 782157a to 6c5a366 Compare February 26, 2020 05:36
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm if green

@jreback jreback merged commit e39cd30 into pandas-dev:master Feb 26, 2020
@jreback
Copy link
Contributor

jreback commented Feb 26, 2020

thanks @cool-RR

in theory we could have a code_checks rule that fails if we don't have from err, but might be non-trivial to do via bash, maybe a linter could do this? (flake plugin)

roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants