BUG: Fix DateFrameGroupBy.mean error for Int64 dtype #32223
Conversation
pandas/tests/groupby/test_apply.py
Outdated
| {"a": [1, 1, 2, 2, 3, 3], "b": [1, 2, 1, 2, 1, 2]}, | ||
| ], | ||
| ) | ||
| @pytest.mark.parametrize("function", ["mean", "median", "var"]) |
There was a problem hiding this comment.
Can you use reduction_func fixture instead of picking these one-off?
There was a problem hiding this comment.
I'm having some trouble using this fixture without making the test very complex since the methods each have different output (e.g., sometimes it's empty), some require arguments, etc. Would it be okay if these tests only included the ones affected by the bug?
pandas/tests/groupby/test_apply.py
Outdated
|
|
||
| @pytest.mark.parametrize( | ||
| "values", | ||
| [ |
There was a problem hiding this comment.
move this to pandas/tests/groupby/test_function.py
|
also merge master |
| groups = pd.DataFrame(values, dtype="Int64").groupby("a") | ||
| result = getattr(groups, function)() | ||
|
|
||
| output = 0.5 if function == "var" else 1.5 |
There was a problem hiding this comment.
move the expected to the top.
| def test_apply_to_nullable_integer_returns_float(values, function): | ||
| # https://github.com/pandas-dev/pandas/issues/32219 | ||
| groups = pd.DataFrame(values, dtype="Int64").groupby("a") | ||
| result = getattr(groups, function)() |
There was a problem hiding this comment.
move result down to the bottom & add testing for
.agg([function]) and .agg(function)
|
|
||
| groups = pd.DataFrame(values, dtype="Int64").groupby("a") | ||
|
|
||
| if use_agg: |
There was a problem hiding this comment.
you don't need to parameterize on use_agg; just test all 3
There was a problem hiding this comment.
@jreback Updated and green
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
|
thanks @dsaxton |
|
@dsaxton if you can try a manual backport would be great :-> |
|
Thanks @dsaxton. FYI, in the future you can remove the "still needs manual backport" label after the backport is merged. |
meanon aDataFrameGroupBywithInt64dtype results inTypeError#32219black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffIt looks like this was due to the
TypeErrornot being caught