BUG: 2D DTA/TDA arithmetic with object-dtype #32185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Feb 23, 2020
pandas/core/arrays/datetimelike.py
Outdated
| # e.g. we've passed a Timestamp to TimedeltaArray | ||
| res = res_values | ||
| return res | ||
| # Note: we are assuming here that shapes match. |
| @@ -2395,3 +2408,31 @@ def test_shift_months(years, months): | |||
| raw = [x + pd.offsets.DateOffset(years=years, months=months) for x in dti] | |||
| expected = DatetimeIndex(raw) | |||
| tm.assert_index_equal(actual, expected) | |||
|
|
|||
|
|
|||
| def test_dt64arr_addsub_object_dtype_2d(): | |||
There was a problem hiding this comment.
ok with either class based or free functions, mixing is slightly odd.
There was a problem hiding this comment.
yah, this is a bit of an odd-man-out because the class-based tests are all trying to use box_with_array, whereas this is specifically aiming at the 2D array case
jreback
added
Bug
Dtype Conversions
|
@jreback gentle ping; this is a blocker for the upcoming blockwise frame-with-frame perf fix |
jreback
approved these changes
Mar 3, 2020
|
thanks. this looks user facing? if so can you follow up with a whatsnew note . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation for this is that it is prerequisite for implementing frame-with-frame ops blockwise. It also fixes a few broken cases: