Skip to content

CLN: unnecessary kwargs for take_with_is_copy #32181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2020
Merged

CLN: unnecessary kwargs for take_with_is_copy #32181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d9b081
CLN: no kwargs for take_with_is_copy
jbrockmendel Feb 19, 2020
f4161f7
Merge branch 'master' of https://github.com/pandas-dev/pandas into ya…
jbrockmendel Feb 21, 2020
5d0ebf3
Merge branch 'master' of https://github.com/pandas-dev/pandas into ya…
jbrockmendel Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3262,17 +3262,15 @@ class max_speed
)
return self._constructor(new_data).__finalize__(self)

def _take_with_is_copy(
self: FrameOrSeries, indices, axis=0, **kwargs
) -> FrameOrSeries:
def _take_with_is_copy(self: FrameOrSeries, indices, axis=0) -> FrameOrSeries:
"""
Internal version of the `take` method that sets the `_is_copy`
attribute to keep track of the parent dataframe (using in indexing
for the SettingWithCopyWarning).

See the docstring of `take` for full explanation of the parameters.
"""
result = self.take(indices=indices, axis=axis, **kwargs)
result = self.take(indices=indices, axis=axis)
# Maybe set copy if we didn't actually change the index.
if not result._get_axis(axis).equals(self._get_axis(axis)):
result._set_is_copy(self)
Expand Down
4 changes: 2 additions & 2 deletions pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@ def take(self, indices, axis=0, is_copy=None, **kwargs) -> "Series":
new_values, index=new_index, fastpath=True
).__finalize__(self)

def _take_with_is_copy(self, indices, axis=0, **kwargs):
def _take_with_is_copy(self, indices, axis=0):
"""
Internal version of the `take` method that sets the `_is_copy`
attribute to keep track of the parent dataframe (using in indexing
Expand All @@ -821,7 +821,7 @@ def _take_with_is_copy(self, indices, axis=0, **kwargs):

See the docstring of `take` for full explanation of the parameters.
"""
return self.take(indices=indices, axis=axis, **kwargs)
return self.take(indices=indices, axis=axis)

def _ixs(self, i: int, axis: int = 0):
"""
Expand Down