DOC: Fix SA04 errors in docstrings xref #28792 #32180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
suggested changes
Feb 22, 2020
There was a problem hiding this comment.
Thanks @AdrianMastronardi
Would this close #28792? If not, prob best to put "xref #28792"
AdrianMastronardi
changed the title
AdrianMastronardi
changed the title
There was a problem hiding this comment.
Thanks @AdrianMastronardi generally lgtm. a couple of suggestions.
Co-Authored-By: Simon Hawkins <[email protected]>
Co-Authored-By: Simon Hawkins <[email protected]>
|
Hello @AdrianMastronardi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-03-03 03:15:34 UTC |
simonjayhawkins
requested changes
Mar 2, 2020
Co-Authored-By: Simon Hawkins <[email protected]>
datapythonista
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
lgtm, thanks @AdrianMastronardi
@simonjayhawkins I think this is ready
simonjayhawkins
approved these changes
Mar 3, 2020
|
Thanks @AdrianMastronardi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff