Import OptionError in pandas.errors #32142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumanau7
force-pushed
the
import_OptionError_in_pandas_errors
branch
from
8f2d630 to
2188d7b
Compare
simonjayhawkins
added
API Design
Error Reporting
|
@jorisvandenbossche I am experiencing a build failure on my forked master as well, is this some setup issue, would need your help to resolve this. Also Is the pr good to go or more changes would be required ? |
|
Travis failure should be unrelated, just restarted that build. |
|
Can you add this to test_exception_importable in tests.test_errors |
sumanau7
force-pushed
the
import_OptionError_in_pandas_errors
branch
from
8f5ed3a to
30c293b
Compare
|
@jbrockmendel Tests are changed, a whatsnew entry is created. Would you be able to review this or suggest someone who can help in reviewing this PR. |
sumanau7
force-pushed
the
import_OptionError_in_pandas_errors
branch
2 times, most recently
from
c38da31 to
f73b8eb
Compare
sumanau7
force-pushed
the
import_OptionError_in_pandas_errors
branch
from
f73b8eb to
3c6c813
Compare
|
@jreback Please review. |
jorisvandenbossche
approved these changes
Feb 24, 2020
jreback
approved these changes
Feb 24, 2020
|
thanks @sumanau7 |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OptionErrorraised by top-level functionpandas.set_optionis private #27553black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff