-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: Avoid ambiguous condition in GroupBy.first / last #32124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
627410d
Add test
dsaxton bb4ad11
Check for NA
dsaxton 3213718
Update whatsnew
dsaxton 58bbb57
Use nulls_fixture
dsaxton 4f2d126
Use checknull
dsaxton c4a6518
Merge branch 'master' into grpby-nth
dsaxton e09bbe6
Merge remote-tracking branch 'upstream/master' into grpby-nth
dsaxton c7c7a95
Merge remote-tracking branch 'upstream/master' into grpby-nth
dsaxton 4329021
Merge remote-tracking branch 'upstream/master' into grpby-nth
dsaxton 87456af
Move and add test
dsaxton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -530,3 +530,23 @@ def test_nth_nan_in_grouper(dropna): | |
) | ||
|
||
tm.assert_frame_equal(result, expected) | ||
|
||
|
||
@pytest.mark.parametrize("method", ["first", "last"]) | ||
def test_first_last_with_na_object(method, nulls_fixture): | ||
# https://github.com/pandas-dev/pandas/issues/32123 | ||
groups = pd.DataFrame({"a": [1, 1, 2, 2], "b": [1, 2, 3, nulls_fixture]}).groupby( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also move this belowt est_first_last_nth (it may actually be simpler to modify that test though) |
||
"a" | ||
) | ||
result = getattr(groups, method)() | ||
|
||
if method == "first": | ||
values = [1, 3] | ||
else: | ||
values = [2, 3] | ||
|
||
values = np.array(values, dtype=result["b"].dtype) | ||
idx = pd.Index([1, 2], name="a") | ||
expected = pd.DataFrame({"b": values}, index=idx) | ||
|
||
tm.assert_frame_equal(result, expected) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also test
.nth(0)
and.nth(-1)
which are the same results (except the nth -1 will have the null as the resultThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a test for nth with nulls; I gave it its own test rather than putting it with first / last to avoid too much awkward if / else branching inside the test