-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
add test for "Allow definition of pd.CategoricalDtype
with a specific categories.dtype
"
#32115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @rushabh-v! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-02-20 09:05:02 UTC |
@TomAugspurger I have added the test. Where should I add the documentation? |
Probably in the CategoricalDtype docstring in |
can you take a look, please? @TomAugspurger |
It’ll be a couple weeks for me.
… On Feb 20, 2020, at 04:12, Rushabh Vasani ***@***.***> wrote:
can you take a look @TomAugspurger please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Thanks @rushabh-v! |
pd.CategoricalDtype
with a specificcategories.dtype
#32096