BUG: Pickle NA objects #32104
Merged
BUG: Pickle NA objects #32104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://docs.python.org/3/library/pickle.html#object.__reduce__, > If a string is returned, the string should be interpreted as the name > of a global variable. It should be the object’s local name relative to > its module; the pickle module searches the module namespace to determine > the object’s module. This behaviour is typically useful for singletons. Closes pandas-dev#31847
TomAugspurger
added
IO Pickle
jreback
reviewed
Feb 19, 2020
jreback
requested changes
Feb 19, 2020
|
@TomAugspurger can you re-push? looks like azure has stalled |
|
It'll be a week or so before I can look at this again.
…On Fri, Feb 21, 2020 at 10:34 AM jbrockmendel ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> can you re-push? looks
like azure has stalled
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#32104?email_source=notifications&email_token=AAKAOIQOCULSNCBWNQBS33TREAGCPA5CNFSM4KXZVAX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMTPIWA#issuecomment-589755480>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKAOIXQS62R266VAIIDX7TREAGCPANCNFSM4KXZVAXQ>
.
|
jreback
requested changes
Feb 22, 2020
|
@TomAugspurger can you rebase and update (small requests) |
|
I think everything has been addressed. |
jorisvandenbossche
approved these changes
Mar 2, 2020
|
Thanks @TomAugspurger ! |
|
@meeseeksdev backport to 1.0.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Mar 2, 2020
jreback
pushed a commit
that referenced
this pull request
Mar 3, 2020
Co-authored-by: Tom Augspurger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
https://docs.python.org/3/library/pickle.html#object.__reduce__,
Closes #31847