Skip to content

TST: Fix bare pytest.raises in test_parsing.py #32102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2020
Merged

TST: Fix bare pytest.raises in test_parsing.py #32102

merged 3 commits into from
Feb 20, 2020

Conversation

mabroor
Copy link
Contributor

@mabroor mabroor commented Feb 19, 2020

Fixes bare pytest.raises issue for test_parsing.py.

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Feb 19, 2020
@mabroor mabroor changed the title Fix bare pytest.raises in test_parsing.py TST: Fix bare pytest.raises in test_parsing.py Feb 20, 2020
@mabroor mabroor requested a review from jbrockmendel February 20, 2020 07:20
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 20, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mabroor thanks for the PR. lgtm. minor comment not blocker

@jbrockmendel
Copy link
Member

LGTM pending @simonjayhawkins comment (on which I have no strong opinion)

@simonjayhawkins simonjayhawkins merged commit 27e18e5 into pandas-dev:master Feb 20, 2020
@simonjayhawkins
Copy link
Member

Thanks @mabroor

roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants