TYP: check_untyped_defs arrays.sparse.array #32099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/arrays/sparse/array.py
Outdated
| if is_scalar(indices): | ||
| raise ValueError(f"'indices' must be an array, not a scalar '{indices}'.") | ||
| indices = np.asarray(indices, dtype=np.int32) | ||
|
|
||
| result: Union[List[Any], np.ndarray] |
There was a problem hiding this comment.
this is just the empty list we get on 808 right? would it make sense to define result = np.array([], dtype=something) there?
There was a problem hiding this comment.
this is just the empty list we get on 808 right?
yes. AFAIK we can't type 'builtins.list[<nothing>]' so List[Any] used instead.
would it make sense to define
result = np.array([], dtype=something)there?
done.
|
lgtm outside of @jbrockmendel question |
|
Thanks @simonjayhawkins |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas\core\arrays\sparse\array.py:807: error: Need type annotation for 'result' (hint: "result: List[] = ...")