Skip to content

POC/REF: remove SeriesBinGrouper, SeriesGrouper #32083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jbrockmendel
Copy link
Member

Maintenance of libreduction is a PITA, so I want to see how big a performance hit we take if we rip it out.

I get a test failure locally because apparently something in resample behaves differently if we go through the python path, which itself should be considered a bug. cc @mroeschke any ideas how to fix the failing test/

@jbrockmendel
Copy link
Member Author

asv run with -b groupby:

       before           after         ratio
     <master>         <no-_aggregate_series_fast>
+         135±3ms       1.75±0.03s    12.94  groupby.MultiColumn.time_lambda_sum
+        71.6±1ms         881±10ms    12.31  groupby.MultiColumn.time_col_select_lambda_sum
+      14.0±0.3ms       15.7±0.3ms     1.12  groupby.Nth.time_frame_nth('float64')

@jbrockmendel jbrockmendel added the Performance Memory or execution speed performance label Feb 19, 2020
@jbrockmendel
Copy link
Member Author

Closing to clear the queue, will revisit. Still hoping to @mroeschke can take a look at the failing test case, since that suggests an extant bug hidden somewhere.

@jbrockmendel jbrockmendel added the Mothballed Temporarily-closed PR the author plans to return to label Apr 21, 2020
@jbrockmendel jbrockmendel deleted the no-_aggregate_series_fast branch August 27, 2020 20:17
@jbrockmendel jbrockmendel removed the Mothballed Temporarily-closed PR the author plans to return to label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant