CLN: Clean reductions/test_reductions.py #32035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Feb 16, 2020
| @pytest.mark.parametrize("dtype", ["M8[ns]", "datetime64[ns, UTC]"]) | ||
| def test_nanops_empty_object(self, opname, index_or_series, dtype): | ||
| klass = index_or_series | ||
| arg_op = "arg" + opname if klass is Index else "idx" + opname |
There was a problem hiding this comment.
I broke this into its own test since it allows for parametrizing over these dtypes without repeating all of test_nanops (which was / is pretty big), and this was conceptually a bit more specific than just "testing nanops"
There was a problem hiding this comment.
i get that, but why is arg_op specifically needed? what is its purpose
There was a problem hiding this comment.
Oh, I think the name of the method being tested changes if it's a Series or Index (idxmin or argmin) so it has to be created dynamically in the test?
jreback
added
Refactor
jreback
approved these changes
Feb 17, 2020
|
thanks @dsaxton |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more parameterizing / splitting up of tests