Skip to content

CLN: GH29547 replace old string formatting #32029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2020
Merged

CLN: GH29547 replace old string formatting #32029

merged 1 commit into from
Feb 15, 2020

Conversation

pcandoalmeida
Copy link
Contributor

Hi there! This is my first contribution. Please let me know if there are any issues, thank you.

  • tests passed
  • passes black pandas

@simonjayhawkins simonjayhawkins added the Code Style Code style, linting, code_checks label Feb 15, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 15, 2020
simonjayhawkins
simonjayhawkins approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pcandoalmeida lgtm

@simonjayhawkins simonjayhawkins merged commit 92a64c7 into pandas-dev:master Feb 15, 2020
@simonjayhawkins
Copy link
Member

Thanks @pcandoalmeida

@pcandoalmeida
Copy link
Contributor Author

Thanks @simonjayhawkins

@pcandoalmeida pcandoalmeida mentioned this pull request Feb 15, 2020
Closed
99 tasks
@pcandoalmeida pcandoalmeida deleted the 29547-fstring-update branch February 15, 2020 20:10
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
@pcandoalmeida @roberthdevries
CLN: GH29547 replace old string formatting (pandas-dev#32029)
7fd1084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@pcandoalmeida @simonjayhawkins