Skip to content

CLN 29574 Replace old string formating #32007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2020
Merged

CLN 29574 Replace old string formating #32007

merged 1 commit into from
Feb 15, 2020

Conversation

panjacek
Copy link
Contributor

@panjacek panjacek commented Feb 15, 2020 •
edited
Loading

Its my first contribution, modified the str formating to use fstrings

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • pandas/tests/frame/test_to_csv.py

@ShaharNaveh ShaharNaveh added the Code Style Code style, linting, code_checks label Feb 15, 2020
ShaharNaveh
ShaharNaveh approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@ShaharNaveh ShaharNaveh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panjacek panjacek mentioned this pull request Feb 15, 2020
Closed
99 tasks
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 15, 2020
simonjayhawkins
simonjayhawkins approved these changes Feb 15, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @panjacek lgtm

@panjacek panjacek changed the title CLN 2574 Replace old string formating CLN 29574 Replace old string formating Feb 15, 2020
@simonjayhawkins simonjayhawkins merged commit 206a547 into pandas-dev:master Feb 15, 2020
@simonjayhawkins
Copy link
Member

Thanks @panjacek

@panjacek panjacek deleted the use_fstrings branch February 15, 2020 19:21
@panjacek panjacek restored the use_fstrings branch February 15, 2020 19:25
@panjacek panjacek deleted the use_fstrings branch February 16, 2020 06:31
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
@panjacek @roberthdevries
CLN 2574 Replace old string formating (pandas-dev#32007)
36afc2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

@ShaharNaveh ShaharNaveh ShaharNaveh approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@panjacek @simonjayhawkins @ShaharNaveh