Skip to content

CLN: D414: Section has no content #31961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonjayhawkins
Copy link
Member

No description provided.

@WillAyd WillAyd modified the milestones: 1.0.2, 1.1 Feb 13, 2020
@WillAyd WillAyd merged commit 870ef1e into pandas-dev:master Feb 13, 2020
@WillAyd
Copy link
Member

WillAyd commented Feb 13, 2020

cool thanks! just out of curiosity how many more checks do you plan on running?

@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Feb 13, 2020

Some others that could be useful may conflict with validate_docstrings or dynamic docstring generation.

pydocstyle is a static checker whereas validate_docstrings imports the docstrings and checks.

pydocstyle can check all static docstrings. validate_docstrings only checks the public docstrings.

I think the new doc decorator could be an advantage here to allow static checking of more of the dynamically generated docstrings.

I think that the 'quick hit' checks done so far would add sufficient value if included in CI and enforced.

I see two main benefits. Long term to improve the quality of non-public docstrings to help contributers, but in the short term to support the review process by formalising some more style nits.

@simonjayhawkins simonjayhawkins deleted the D414--Section-has-no-content branch February 13, 2020 20:31
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants